Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Jun 4, 2019

No description provided.

@pitrou pitrou changed the title [ARROW-5511] Enable Flight in Conda packages ARROW-5511: [Packaging] Enable Flight in Conda packages Jun 5, 2019
@pitrou
Copy link
Member

pitrou commented Jun 5, 2019

@kszucs

@pitrou
Copy link
Member

pitrou commented Jun 6, 2019

Does it work? I get the following error here:

$ conda build dev/tasks/conda-recipes/arrow-cpp/
No numpy version specified in conda_build_config.yaml.  Falling back to default numpy value of 1.11
WARNING:conda_build.metadata:No numpy version specified in conda_build_config.yaml.  Falling back to default numpy value of 1.11
Adding in variants from internal_defaults
INFO:conda_build.variants:Adding in variants from internal_defaults
Attempting to finalize metadata for arrow-cpp
INFO:conda_build.metadata:Attempting to finalize metadata for arrow-cpp
Traceback (most recent call last):
  File "/home/antoine/miniconda3/lib/python3.7/site-packages/conda_build/utils.py", line 1321, in _increment
    last_version = str(int(version) + 1) + suffix
ValueError: invalid literal for int() with base 10: 'none'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/antoine/miniconda3/bin/conda-build", line 11, in <module>
    sys.exit(main())
  File "/home/antoine/miniconda3/lib/python3.7/site-packages/conda_build/cli/main_build.py", line 456, in main
    execute(sys.argv[1:])
  File "/home/antoine/miniconda3/lib/python3.7/site-packages/conda_build/cli/main_build.py", line 447, in execute
    verify=args.verify, variants=args.variants)
  File "/home/antoine/miniconda3/lib/python3.7/site-packages/conda_build/api.py", line 208, in build
    notest=notest, need_source_download=need_source_download, variants=variants)
  File "/home/antoine/miniconda3/lib/python3.7/site-packages/conda_build/build.py", line 2314, in build_tree
    notest=notest,
  File "/home/antoine/miniconda3/lib/python3.7/site-packages/conda_build/build.py", line 1324, in build
    output_metas = expand_outputs([(m, need_source_download, need_reparse_in_env)])
  File "/home/antoine/miniconda3/lib/python3.7/site-packages/conda_build/render.py", line 735, in expand_outputs
    for (output_dict, m) in _m.copy().get_output_metadata_set(permit_unsatisfiable_variants=False):
  File "/home/antoine/miniconda3/lib/python3.7/site-packages/conda_build/metadata.py", line 2038, in get_output_metadata_set
    bypass_env_check=bypass_env_check)
  File "/home/antoine/miniconda3/lib/python3.7/site-packages/conda_build/metadata.py", line 715, in finalize_outputs_pass
    output_d = om.get_rendered_output(metadata.name()) or {'name': metadata.name()}
  File "/home/antoine/miniconda3/lib/python3.7/site-packages/conda_build/metadata.py", line 2095, in get_rendered_output
    permit_undefined_jinja=permit_undefined_jinja):
  File "/home/antoine/miniconda3/lib/python3.7/site-packages/conda_build/metadata.py", line 2084, in get_rendered_outputs_section
    allow_no_other_outputs=permit_undefined_jinja)) or
  File "/home/antoine/miniconda3/lib/python3.7/site-packages/conda_build/metadata.py", line 1525, in _get_contents
    rendered = template.render(environment=env)
  File "/home/antoine/miniconda3/lib/python3.7/site-packages/jinja2/asyncsupport.py", line 76, in render
    return original_render(self, *args, **kwargs)
  File "/home/antoine/miniconda3/lib/python3.7/site-packages/jinja2/environment.py", line 1008, in render
    return self.environment.handle_exception(exc_info, True)
  File "/home/antoine/miniconda3/lib/python3.7/site-packages/jinja2/environment.py", line 780, in handle_exception
    reraise(exc_type, exc_value, tb)
  File "/home/antoine/miniconda3/lib/python3.7/site-packages/jinja2/_compat.py", line 37, in reraise
    raise value.with_traceback(tb)
  File "/home/antoine/arrow/dev/dev/tasks/conda-recipes/arrow-cpp/meta.yaml", line 13, in top-level template code
    # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
  File "/home/antoine/miniconda3/lib/python3.7/site-packages/conda_build/jinja_context.py", line 324, in pin_subpackage
    exact, permit_undefined_jinja)
  File "/home/antoine/miniconda3/lib/python3.7/site-packages/conda_build/jinja_context.py", line 295, in pin_subpackage_against_outputs
    max_pin))
  File "/home/antoine/miniconda3/lib/python3.7/site-packages/conda_build/utils.py", line 1351, in apply_pin_expressions
    v = _increment(v, alpha_ver)
  File "/home/antoine/miniconda3/lib/python3.7/site-packages/conda_build/utils.py", line 1323, in _increment
    last_version = chr(ord(version) + 1)
TypeError: ord() expected a character, but string of length 4 found

@ghost
Copy link
Author

ghost commented Jun 6, 2019

It's because ARROW_VERSION needs to be set (the CI scripts do so) env ARROW_VERSION=0.14.0 conda build dev/tasks/conda-recipes/arrow-cpp/

@pitrou
Copy link
Member

pitrou commented Jun 6, 2019

Now I get another error:

$ ARROW_VERSION=0.14.0 conda build dev/tasks/conda-recipes/arrow-cpp/
No numpy version specified in conda_build_config.yaml.  Falling back to default numpy value of 1.11
WARNING:conda_build.metadata:No numpy version specified in conda_build_config.yaml.  Falling back to default numpy value of 1.11
Adding in variants from internal_defaults
INFO:conda_build.variants:Adding in variants from internal_defaults
Attempting to finalize metadata for arrow-cpp
INFO:conda_build.metadata:Attempting to finalize metadata for arrow-cpp
Collecting package metadata: ...working... done
Solving environment: ...working... failed

Leaving build/test directories:
  Work:
 /home/antoine/miniconda3/conda-bld/work 
  Test:
 /home/antoine/miniconda3/conda-bld/test_tmp 
Leaving build/test environments:
  Test:
source activate  /home/antoine/miniconda3/conda-bld/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_ 
  Build:
source activate  /home/antoine/miniconda3/conda-bld/_build_env 


Traceback (most recent call last):
  File "/home/antoine/miniconda3/lib/python3.7/site-packages/conda_build/environ.py", line 753, in get_install_actions
    actions = install_actions(prefix, index, specs, force=True)
  File "/home/antoine/miniconda3/lib/python3.7/site-packages/conda/common/io.py", line 88, in decorated
    return f(*args, **kwds)
  File "/home/antoine/miniconda3/lib/python3.7/site-packages/conda/plan.py", line 473, in install_actions
    txn = solver.solve_for_transaction(prune=prune, ignore_pinned=not pinned)
  File "/home/antoine/miniconda3/lib/python3.7/site-packages/conda/core/solve.py", line 107, in solve_for_transaction
    force_remove, force_reinstall)
  File "/home/antoine/miniconda3/lib/python3.7/site-packages/conda/core/solve.py", line 145, in solve_for_diff
    force_remove)
  File "/home/antoine/miniconda3/lib/python3.7/site-packages/conda/core/solve.py", line 242, in solve_final_state
    ssc = self._run_sat(ssc)
  File "/home/antoine/miniconda3/lib/python3.7/site-packages/conda/common/io.py", line 88, in decorated
    return f(*args, **kwds)
  File "/home/antoine/miniconda3/lib/python3.7/site-packages/conda/core/solve.py", line 475, in _run_sat
    conflicting_specs = ssc.r.get_conflicting_specs(tuple(final_environment_specs))
  File "/home/antoine/miniconda3/lib/python3.7/site-packages/conda/resolve.py", line 852, in get_conflicting_specs
    reduced_index = self.get_reduced_index(specs)
  File "/home/antoine/miniconda3/lib/python3.7/site-packages/conda/common/io.py", line 88, in decorated
    return f(*args, **kwds)
  File "/home/antoine/miniconda3/lib/python3.7/site-packages/conda/resolve.py", line 356, in get_reduced_index
    specs, features = self.verify_specs(specs)
  File "/home/antoine/miniconda3/lib/python3.7/site-packages/conda/resolve.py", line 244, in verify_specs
    raise ResolvePackageNotFound(bad_deps)
conda.exceptions.ResolvePackageNotFound: 
  - re2
  - clangdev=7

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/antoine/miniconda3/bin/conda-build", line 11, in <module>
    sys.exit(main())
  File "/home/antoine/miniconda3/lib/python3.7/site-packages/conda_build/cli/main_build.py", line 456, in main
    execute(sys.argv[1:])
  File "/home/antoine/miniconda3/lib/python3.7/site-packages/conda_build/cli/main_build.py", line 447, in execute
    verify=args.verify, variants=args.variants)
  File "/home/antoine/miniconda3/lib/python3.7/site-packages/conda_build/api.py", line 208, in build
    notest=notest, need_source_download=need_source_download, variants=variants)
  File "/home/antoine/miniconda3/lib/python3.7/site-packages/conda_build/build.py", line 2314, in build_tree
    notest=notest,
  File "/home/antoine/miniconda3/lib/python3.7/site-packages/conda_build/build.py", line 1324, in build
    output_metas = expand_outputs([(m, need_source_download, need_reparse_in_env)])
  File "/home/antoine/miniconda3/lib/python3.7/site-packages/conda_build/render.py", line 735, in expand_outputs
    for (output_dict, m) in _m.copy().get_output_metadata_set(permit_unsatisfiable_variants=False):
  File "/home/antoine/miniconda3/lib/python3.7/site-packages/conda_build/metadata.py", line 2038, in get_output_metadata_set
    bypass_env_check=bypass_env_check)
  File "/home/antoine/miniconda3/lib/python3.7/site-packages/conda_build/metadata.py", line 715, in finalize_outputs_pass
    output_d = om.get_rendered_output(metadata.name()) or {'name': metadata.name()}
  File "/home/antoine/miniconda3/lib/python3.7/site-packages/conda_build/metadata.py", line 2095, in get_rendered_output
    permit_undefined_jinja=permit_undefined_jinja):
  File "/home/antoine/miniconda3/lib/python3.7/site-packages/conda_build/metadata.py", line 2084, in get_rendered_outputs_section
    allow_no_other_outputs=permit_undefined_jinja)) or
  File "/home/antoine/miniconda3/lib/python3.7/site-packages/conda_build/metadata.py", line 1525, in _get_contents
    rendered = template.render(environment=env)
  File "/home/antoine/miniconda3/lib/python3.7/site-packages/jinja2/asyncsupport.py", line 76, in render
    return original_render(self, *args, **kwargs)
  File "/home/antoine/miniconda3/lib/python3.7/site-packages/jinja2/environment.py", line 1008, in render
    return self.environment.handle_exception(exc_info, True)
  File "/home/antoine/miniconda3/lib/python3.7/site-packages/jinja2/environment.py", line 780, in handle_exception
    reraise(exc_type, exc_value, tb)
  File "/home/antoine/miniconda3/lib/python3.7/site-packages/jinja2/_compat.py", line 37, in reraise
    raise value.with_traceback(tb)
  File "/home/antoine/arrow/dev/dev/tasks/conda-recipes/arrow-cpp/meta.yaml", line 46, in top-level template code
    - glog
  File "/home/antoine/miniconda3/lib/python3.7/site-packages/conda_build/jinja_context.py", line 230, in pin_compatible
    pins, _, _ = get_env_dependencies(m, 'host', m.config.variant)
  File "/home/antoine/miniconda3/lib/python3.7/site-packages/conda_build/render.py", line 143, in get_env_dependencies
    channel_urls=tuple(m.config.channel_urls))
  File "/home/antoine/miniconda3/lib/python3.7/site-packages/conda_build/environ.py", line 755, in get_install_actions
    raise DependencyNeedsBuildingError(exc, subdir=subdir)
conda_build.exceptions.DependencyNeedsBuildingError: Unsatisfiable dependencies for platform linux-64: {'clangdev=7', 're2'}

@ghost
Copy link
Author

ghost commented Jun 6, 2019

Ah sorry, forgot conda-forge is needed, and there appears to be a config file to pin certain packages: env ARROW_VERSION=0.14.0 conda build dev/tasks/conda-recipes/arrow-cpp/ -c conda-forge -m dev/tasks/conda-recipes/variants/osx_python3.7.yaml (of course use linux_python3.7.yaml or your desired config)

@pitrou
Copy link
Member

pitrou commented Jun 6, 2019

Thanks :-) It finally worked.

@kszucs
Copy link
Member

kszucs commented Jun 11, 2019

Looks good to me, but let me check via crossbow.

@pitrou
Copy link
Member

pitrou commented Jun 24, 2019

@ursabot crossbow build -g conda

@ursabot
Copy link

ursabot commented Jun 24, 2019

No such command "build".

@pitrou
Copy link
Member

pitrou commented Jun 24, 2019

@ursabot crossbow package -g conda

@ursabot
Copy link

ursabot commented Jun 24, 2019

AMD64 Conda Crossbow (#24815) builder failed.

Revision: 5685d10c4765b1bf5b34722339825d7f233b51e4

Crossbow: 'python crossbow.py ...' step's stderr:

Traceback (most recent call last):
  File "crossbow.py", line 937, in <module>
    crossbow(obj={}, auto_envvar_prefix='CROSSBOW')
  File "/opt/conda/lib/python3.7/site-packages/click/core.py", line 764, in __call__
    return self.main(*args, **kwargs)
  File "/opt/conda/lib/python3.7/site-packages/click/core.py", line 717, in main
    rv = self.invoke(ctx)
  File "/opt/conda/lib/python3.7/site-packages/click/core.py", line 1137, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/opt/conda/lib/python3.7/site-packages/click/core.py", line 956, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/opt/conda/lib/python3.7/site-packages/click/core.py", line 555, in invoke
    return callback(*args, **kwargs)
  File "/opt/conda/lib/python3.7/site-packages/click/decorators.py", line 17, in new_func
    return f(get_current_context(), *args, **kwargs)
  File "crossbow.py", line 761, in submit
    tasks[name] = Task(artifacts=artifacts, **task)
TypeError: __init__() missing 1 required positional argument: 'ci'

@pitrou
Copy link
Member

pitrou commented Jun 24, 2019

@ursabot crossbow package -g conda

@ursabot
Copy link

ursabot commented Jun 24, 2019

AMD64 Conda Crossbow (#24824) builder has been succeeded.

Revision: 584ba8404c95810b4cf4e59209a4e438036989df

Submitted crossbow builds: ursa-labs/crossbow @ ursabot-58

Task Status
conda-win-vs2015-py37 Appveyor Status
conda-osx-clang-py36 TravisCI Status
conda-linux-gcc-py36 TravisCI Status
conda-win-vs2015-py36 Appveyor Status
conda-linux-gcc-py37 TravisCI Status
conda-osx-clang-py27 TravisCI Status
conda-linux-gcc-py27 TravisCI Status
conda-osx-clang-py37 TravisCI Status

@pitrou
Copy link
Member

pitrou commented Jun 24, 2019

@ursabot crossbow package -g conda

@ursabot
Copy link

ursabot commented Jun 24, 2019

AMD64 Conda Crossbow (#24851) builder has been succeeded.

Revision: eda0f67ff60f6d0e5fd51d2e0042a2b34b973cf5

Submitted crossbow builds: ursa-labs/crossbow @ ursabot-59

Task Status
conda-linux-gcc-py36 TravisCI Status
conda-osx-clang-py27 TravisCI Status
conda-linux-gcc-py27 TravisCI Status
conda-osx-clang-py37 TravisCI Status
conda-win-vs2015-py36 Appveyor Status
conda-osx-clang-py36 TravisCI Status
conda-win-vs2015-py37 Appveyor Status
conda-linux-gcc-py37 TravisCI Status

@pitrou
Copy link
Member

pitrou commented Jun 24, 2019

Unfortunately the crossbow conda builds seem broken on git master. I don't think we can merge this until they're fixed :-/ @wesm @kszucs

@kszucs
Copy link
Member

kszucs commented Jun 24, 2019

I'm working on it #4649

@pitrou
Copy link
Member

pitrou commented Jun 26, 2019

@kszucs Could you help rebasing this and fixing conflicts? Thanks :-)

@ghost
Copy link
Author

ghost commented Jun 26, 2019

I just rebased this.

@kszucs
Copy link
Member

kszucs commented Jun 26, 2019

I've just fetched it :)
Let's fire the packaging tasks.

@kszucs
Copy link
Member

kszucs commented Jun 26, 2019

@ursabot crossbow package -g conda

@ursabot
Copy link

ursabot commented Jun 26, 2019

AMD64 Conda Crossbow (#26191) builder has been succeeded.

Revision: f1e8b5db3fc27ef8ba6673df5fb0ae911647e3aa

Submitted crossbow builds: ursa-labs/crossbow @ ursabot-77

Task Status
conda-linux-gcc-py27 Azure
conda-linux-gcc-py36 Azure
conda-linux-gcc-py37 Azure
conda-osx-clang-py27 Azure
conda-osx-clang-py36 Azure
conda-osx-clang-py37 Azure
conda-win-vs2015-py36 Appveyor
conda-win-vs2015-py37 Appveyor

@pitrou
Copy link
Member

pitrou commented Jun 26, 2019

@lihalite Can you add a test that pyarrow.flight imports?

@ghost
Copy link
Author

ghost commented Jun 26, 2019

@pitrou done.

@pitrou
Copy link
Member

pitrou commented Jun 26, 2019

@ursabot crossbow package -g conda

@ursabot
Copy link

ursabot commented Jun 26, 2019

AMD64 Conda Crossbow (#26209) builder has been succeeded.

Revision: 689d61de2bcf2859cb44cd08f58e9072e0c73214

Submitted crossbow builds: ursa-labs/crossbow @ ursabot-79

Task Status
conda-linux-gcc-py27 Azure
conda-linux-gcc-py36 Azure
conda-linux-gcc-py37 Azure
conda-osx-clang-py27 Azure
conda-osx-clang-py36 Azure
conda-osx-clang-py37 Azure
conda-win-vs2015-py36 Appveyor
conda-win-vs2015-py37 Appveyor

@pitrou
Copy link
Member

pitrou commented Jun 26, 2019

Not sure what happened but this build fails on uriparser: https://dev.azure.com/ursa-labs/crossbow/_build/results?buildId=123
@kszucs

@kszucs
Copy link
Member

kszucs commented Jun 26, 2019

@ursabot crossbow package conda-linux-gcc-py37

@apache apache deleted a comment from ursabot Jun 26, 2019
@kszucs
Copy link
Member

kszucs commented Jun 26, 2019

@ursabot crossbow package conda-linux-gcc-py37

@ursabot
Copy link

ursabot commented Jun 26, 2019

AMD64 Conda Crossbow (#26379) builder has been succeeded.

Revision: 7ca809be7c46a1f0bf299c4f143ab5dc950e8c61

Submitted crossbow builds: ursa-labs/crossbow @ ursabot-84

Task Status
conda-linux-gcc-py37 Azure

@kszucs
Copy link
Member

kszucs commented Jun 27, 2019

@ursabot crossbow package conda-linux-gcc-py37

@ursabot
Copy link

ursabot commented Jun 27, 2019

AMD64 Conda Crossbow (#27029) builder has been succeeded.

Revision: f612508

Submitted crossbow builds: ursa-labs/crossbow @ ursabot-90

Task Status
conda-linux-gcc-py37 Azure

-DCMAKE_INSTALL_LIBDIR=$PREFIX/lib \
-DLLVM_TOOLS_BINARY_DIR=$PREFIX/bin \
-DARROW_DEPENDENCY_SOURCE=SYSTEM \
-Duriparser_SOURCE=BUNDLED \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that we need to package uriparser before we can release this on conda-forge; there bundling of thirdparties is not really accepted.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update, didn't know that.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even for small private dependencies?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can temporarily statically-link uriparser, we had a bunch of stuff statically linked on conda-forge for a long time before the CMake refactor

@kszucs
Copy link
Member

kszucs commented Jun 27, 2019

@ursabot crossbow package -g conda

@ursabot
Copy link

ursabot commented Jun 27, 2019

AMD64 Conda Crossbow (#27040) builder has been succeeded.

Revision: e764a59

Submitted crossbow builds: ursa-labs/crossbow @ ursabot-91

Task Status
conda-linux-gcc-py27 Azure
conda-linux-gcc-py36 Azure
conda-linux-gcc-py37 Azure
conda-osx-clang-py27 Azure
conda-osx-clang-py36 Azure
conda-osx-clang-py37 Azure
conda-win-vs2015-py36 Appveyor
conda-win-vs2015-py37 Appveyor

@kszucs
Copy link
Member

kszucs commented Jun 27, 2019

@ursabot crossbow package conda-osx-clang-py27 conda-osx-clang-py36

@ursabot
Copy link

ursabot commented Jun 27, 2019

AMD64 Conda Crossbow (#27173) builder has been succeeded.

Revision: c0b95ac

Submitted crossbow builds: ursa-labs/crossbow @ ursabot-93

Task Status
conda-osx-clang-py27 Azure
conda-osx-clang-py36 Azure

@kszucs
Copy link
Member

kszucs commented Jun 27, 2019

Conda probably doesn't move the submodules to the testing directory, skipping the tests instead.

@kszucs
Copy link
Member

kszucs commented Jun 27, 2019

@ursabot crossbow package -g conda

@ursabot
Copy link

ursabot commented Jun 27, 2019

AMD64 Conda Crossbow (#27225) builder has been succeeded.

Revision: c1baa4c

Submitted crossbow builds: ursa-labs/crossbow @ ursabot-94

Task Status
conda-linux-gcc-py27 Azure
conda-linux-gcc-py36 Azure
conda-linux-gcc-py37 Azure
conda-osx-clang-py27 Azure
conda-osx-clang-py36 Azure
conda-osx-clang-py37 Azure
conda-win-vs2015-py36 Appveyor
conda-win-vs2015-py37 Appveyor

@codecov-io
Copy link

Codecov Report

Merging #4473 into master will decrease coverage by 21.45%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #4473       +/-   ##
===========================================
- Coverage   86.42%   64.96%   -21.46%     
===========================================
  Files         989      482      -507     
  Lines      137498    63194    -74304     
  Branches     1418        0     -1418     
===========================================
- Hits       118834    41057    -77777     
- Misses      18302    22137     +3835     
+ Partials      362        0      -362
Impacted Files Coverage Δ
python/pyarrow/tests/test_flight.py 70.58% <100%> (+0.06%) ⬆️
cpp/src/arrow/util/memory.h 0% <0%> (-100%) ⬇️
cpp/src/gandiva/date_utils.h 0% <0%> (-100%) ⬇️
cpp/src/arrow/util/memory.cc 0% <0%> (-100%) ⬇️
cpp/src/arrow/filesystem/util-internal.cc 0% <0%> (-100%) ⬇️
cpp/src/arrow/util/sse-util.h 0% <0%> (-100%) ⬇️
cpp/src/gandiva/decimal_type_util.h 0% <0%> (-100%) ⬇️
cpp/src/arrow/compute/logical_type.h 0% <0%> (-100%) ⬇️
cpp/src/parquet/hasher.h 0% <0%> (-100%) ⬇️
cpp/src/gandiva/basic_decimal_scalar.h 0% <0%> (-100%) ⬇️
... and 745 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2264791...c1baa4c. Read the comment docs.

@wesm
Copy link
Member

wesm commented Jun 27, 2019

Ugly mess of conda-build warnings in the Windows build

https://gist.github.com/wesm/fdbdcfb0882ecba6d27d563566c90532

I'm looking at the Windows build script

@wesm
Copy link
Member

wesm commented Jun 27, 2019

@ursabot crossbow package conda-win-vs2015-py36 conda-win-vs2015-py37

@wesm
Copy link
Member

wesm commented Jun 27, 2019

@ursabot crossbow package conda-win-vs2015-py36 conda-win-vs2015-py37

Copy link
Member

@wesm wesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. The Windows builds are passing now

@wesm
Copy link
Member

wesm commented Jun 28, 2019

@wesm wesm closed this in a0c1c04 Jun 28, 2019
@kszucs
Copy link
Member

kszucs commented Jun 28, 2019

@wesm thanks for fixing the windows builds. When use use [skip ci] pattern in the commit message, then ursabot will skip executing that particular commit. It is because we proxy the request to the standard PR building mechanism of buildbot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants